[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bacula-devel] patch: sorting on bat joblist

I made the most stupid mistake with the sorting patch.
QT sorts only alphabetically, so all numeric fields are messed up, including obviously the jobid. I suppose there is a way to have QT sort properly, but at this time I haven't found one, so perhaps the best solution is to disable column sorting.
Dirk, please apply the attached patch until a better solution comes up.

I'm terribly sorry for all the trouble.

Dirk Bartley wrote:
This patch has been applied to the svn.  Kern, If you would be willing
to view the changes to the console class, that would be apprecieated.

On Sat, 2008-05-17 at 19:50 +0200, rghetta wrote:
Hello Dirk and Kern,
attached you find the sorting patch we discussed.
To recap:
- change joblist ordering to jobid descending.
- enable column sorting as suggested by Marc Schiffbauer

Listing of Job files was very slow on my machine, so I added a buffer of about 8KB to console::displayToPrompt() to speed thing up.

Index: bacula/src/qt-console/joblist/joblist.cpp
--- bacula/src/qt-console/joblist/joblist.cpp	(revision 6981)
+++ bacula/src/qt-console/joblist/joblist.cpp	(working copy)
@@ -207,8 +207,9 @@
    /* set default sorting */
-   mp_tableWidget->sortByColumn(m_jobIdIndex, Qt::DescendingOrder);
-   mp_tableWidget->setSortingEnabled(true);
+   /* QT automatic sorting does only alpha sorting
+      mp_tableWidget->sortByColumn(m_jobIdIndex, Qt::DescendingOrder);
+	mp_tableWidget->setSortingEnabled(true); */
    /* Resize the columns */
This SF.net email is sponsored by: Microsoft 
Defy all challenges. Microsoft(R) Visual Studio 2008. 
Bacula-devel mailing list

This mailing list archive is a service of Copilotco.