[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bacula-devel] problem MaxFullInterval and Copy Jobs


On Wednesday 10 September 2008 11:51:10 Ulrich Leodolter wrote:
> On Wed, 2008-09-10 at 11:35 +0200, Kern Sibbald wrote:
> > On Wednesday 10 September 2008 11:16:12 Ulrich Leodolter wrote:
> > > sorry, now i looked closer at the code, job selection looks
> > > ok but here is the problem:
> > >
> > > fd_cmds.c:206:
> > >
> > > 	do_full = ((now - full_time) <= jcr->job->MaxFullInterval);
> > >
> > > <= should be replaced be > or >=
> > > (maybe full_time should be renamed to last_full_time)
> >
> > Yes, you are absolutely correct.  I have replaced the test by >= and for
> > clarity I changed the variable to last_full_time as well.
>
> same problem applies to MaxDiffInterval
> maybe change diff_time to last_diff_time :-)

Duh, stupid of me -- I am not awake yet.  I should have checked that.

It is now fixed.

Now you have two bugs under your belt :-)

Thanks,

Kern

>
> thanks,
> ulrich
>
> > Thanks for testing this :-)
> >
> > Thanks,
> >
> > Kern
> >
> > > best regards
> > > ulrich
> > >
> > > On Wed, 2008-09-10 at 10:56 +0200, Ulrich Leodolter wrote:
> > > > hello,
> > > >
> > > > yesterday i modified a job and added
> > > >
> > > > 	MaxFullInterval = 10 days
> > > >
> > > > but tonight an unexpected job level upgrade happend:
> > > >
> > > > 	Backup Level:           Full (upgraded from Incremental)
> > > >
> > > > last successful full backup for this job terminated on sunday
> > > > (less than 10 days ago).
> > > >
> > > >
> > > > i think the problem a are my Copy Job entries.
> > > > as u know i am running a daily CopyDiskToTape job.
> > > >
> > > > each copy job entry has level Full and Zero Files and Type='C',
> > > > these jobs should be excluded for Max[Full|Diff]Interval selection.
> > > >
> > > >
> > > > db_find_last_job_start_time(..., L_FULL) is too simple,
> > > >
> > > > i think Job.Type should go into the sql selection,
> > > > but im unsure if Job.Type!='C' or Job.Type in ('B', ... )
> > > > is the better way.
> > > >
> > > >
> > > > fd_cmds.c:203:      if (have_full && jcr->job->MaxFullInterval > 0 &&
> > > > fd_cmds.c-204-         db_find_last_job_start_time(jcr, jcr->db,
> > > > &jcr->jr, &stime, L_FULL)) {
> > > > fd_cmds.c-205-         full_time = str_to_utime(stime);
> > > > fd_cmds.c:206:         do_full = ((now - full_time) <=
> > > > jcr->job->MaxFullInterval);
> > > > fd_cmds.c-207-      }
> > > >
> > > >
> > > > i think this is my first bug report :-)
> > > > best regards
> > > > ulrich



-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Bacula-devel mailing list
Bacula-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/bacula-devel


This mailing list archive is a service of Copilot Consulting.