[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bacula-devel] The sqlquery command is broken by src/console/console.c r6862


On Monday 18 August 2008 13:05:07 Martin Simmons wrote:
> >>>>> On Sat, 16 Aug 2008 12:44:37 +0200, Kern Sibbald said:
> >
> > On Tuesday 08 July 2008 15:40:59 Martin Simmons wrote:
> > > Revision 6862 of src/console/console.c changed the console reader to
> > > split lines on semicolon, which makes it impossible to send the
> > > semicolon terminator that the sqlquery command requires.
> > >
> > > The only reliable eol char is one that is never valid in an SQL
> > > command, which I think is impossible to achieve given that SQL commands
> > > might contain filenames.
> > >
> > > This bug only affects svn at the moment, because it seems that 2.4 is a
> > > branch of 2.2 (which I hadn't realized).
> >
> > I have attempted to fix this (actually some time ago), but have not
> > tested my changes because I don't use readline, so if you are able to
> > test this with the current SVN, I would appreciate some feedback if this
> > has been corrected.
> >
> > Basically the change was allow the EOL character to be turned on/off, and
> > by default it is turned off  (actually set to '0').
>
> Thanks, that works well.  It needs to return after setting it though:
>
> Index: src/console/console.c
> ===================================================================
> --- src/console/console.c	(revision 7493)
> +++ src/console/console.c	(working copy)
> @@ -356,6 +356,7 @@
>        return 1;
>     } else if (argc == 1) {
>        eol = '\0';
> +      return 1;
>     }
>
>     sendit(_("Illegal separator character.\n"));

Ah.  I'm glad I asked you to check it.  Many thanks :-)

Fixed in SVN, and simplified the code to have only one return.

Kern


>
> __Martin
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's
> challenge Build the coolest Linux based applications with Moblin SDK & win
> great prizes Grand prize is a trip for two to an Open Source event anywhere
> in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Bacula-devel mailing list
> Bacula-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/bacula-devel



-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Bacula-devel mailing list
Bacula-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/bacula-devel


This mailing list archive is a service of Copilotco.