[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bacula-devel] is this code intentionally?


On Friday 08 February 2008 23.51:21 Attila Fülöp wrote:
> Kern Sibbald wrote:
> > Although your patch is in a format that I have never seen before, it
> > looks
>
> Hmm...  Looks like a new-style context diff to me... (TM Larry Wall)
>
> diff -c -C 3 from-file to-file
>
> Actually it's quite common.

Well, I figured it out, but I much prefer the "unified" diff, which is pretty 
much universally used.

   diff -u from-file to-file

Kern

>
> > correct to me, so I have applied it to my working copy which will be
> > committed to the trunk sometime today.
> >
> > Thanks
> >
> > Kern
> >
> > On Thursday 07 February 2008 12.55:15 Peter Much wrote:
> >> Dear all,
> >>   an incremental job without any since-date ...
> >>
> >> [from the log:]
> >>
> >>> Backup Level:         Incremental
> >>
> >>   ... is a funny thing.
> >>
> >> It happens when you start a job from the Run= directive
> >> of another job and do *not* give a "Since=" in the Run=
> >> directive.
> >>
> >> I do not know if there is an intention behind that - if so,
> >> then I do not get it. If not, then I might suggest to change
> >> the code, be it for the "philosophy of least surprise".
> >>
> >> Maybe there is no point ever in using the Run= directive *without*
> >> the since option - but if somebody really wants to work with
> >> "mirrored" backups, then they most likely will think very carefully
> >> about how their since-timestamps get derived, and likely they will
> >> do some testing and experimenting on that.
> >> And I can say, during such testing one goes quite crazy with this
> >> effect in place...
> >>
> >> BTW: I must say that I think I have almost never seen a code so
> >>      well documented and well structured. I bow in humility and
> >>      respectfulness.
> >>
> >> rgds,
> >> PMc
> >>
> >> *** src/dird/fd_cmds.c.orig     Wed Oct  3 13:36:47 2007
> >> --- src/dird/fd_cmds.c  Thu Feb  7 03:57:49 2008
> >> ***************
> >> *** 166,173 ****
> >>         if (jcr->stime && jcr->stime[0]) {
> >>            bstrncpy(since, _(", since="), since_len);
> >>            bstrncat(since, jcr->stime, since_len);
> >>         }
> >> -       return;
> >>      }
> >>      if (!jcr->stime) {
> >>         jcr->stime = get_pool_memory(PM_MESSAGE);
> >> --- 166,173 ----
> >>         if (jcr->stime && jcr->stime[0]) {
> >>            bstrncpy(since, _(", since="), since_len);
> >>            bstrncat(since, jcr->stime, since_len);
> >> +          return;
> >>         }
> >>      }
> >>      if (!jcr->stime) {
> >>         jcr->stime = get_pool_memory(PM_MESSAGE);
> >
> > -------------------------------------------------------------------------
> > This SF.net email is sponsored by: Microsoft
> > Defy all challenges. Microsoft(R) Visual Studio 2008.
> > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> > _______________________________________________
> > Bacula-devel mailing list
> > Bacula-devel@xxxxxxxxxxxxxxxxxxxxx
> > https://lists.sourceforge.net/lists/listinfo/bacula-devel
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Bacula-devel mailing list
> Bacula-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/bacula-devel



-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bacula-devel mailing list
Bacula-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/bacula-devel


This mailing list archive is a service of Copilot Consulting.